Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the official version of the compiler service instead of a fork. #497

Closed
safesparrow opened this issue Mar 8, 2023 · 1 comment
Closed

Comments

@safesparrow
Copy link

safesparrow commented Mar 8, 2023

Hi,

I would love if the plugin used the official version of the compiler without the need for custom code changes to be applied.

I know this was previously discussed and there are some obstacles.

Nonetheless I would like to report that achieving that would make it easier for people to contribute to the plugin and test FCS changes against Rider even before they are merged to master, without dealing with lots of merge conflicts or similar issues. This would benefit Rider in the long term.

Related issue, also in the "Makes contributions easier" space: #494

@auduchinok
Copy link
Member

We've discussed it with @safesparrow and @nojaf, and I'm going to close this issue. We're not going to migrate from the fork, as it'll bring too many technical issues to fix along the way. The best thing would be to try to update our fork more often and to make it easier to use a self-built FCS, to make it easier to test local FCS changes in the plugin.

@auduchinok auduchinok closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants