Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling client.quit() does not disconnect the client from eventloop #17

Open
CounterPillow opened this issue Feb 24, 2016 · 1 comment

Comments

@CounterPillow
Copy link

If quit is called on the client, it is not removed from the eventloop as it should when it disconnects. This means run() does not return even if there are no clients left.

EDIT: Technically I'm calling diggler's CommandContext quit(), though I assume it just forwards the call.

EDIT2: In fact, removing the client manually from the event loop does not remove it from the event loop either, so I'm guessing remove is just broken.

@dazoe
Copy link

dazoe commented Mar 8, 2016

I was running into different problems with quit. When I call quit my quit message never makes it to other irc clients. I suspect it's due to quit(...) calling socket.close right after sending the quit message.
As for the eventloop, it throws an exception unless i remove the client with eventloop.remove(client) before calling client.quit(msg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants