Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client disconnects when password contains extended ASCII #132

Open
txtsd opened this issue Jan 27, 2022 · 4 comments
Open

Client disconnects when password contains extended ASCII #132

txtsd opened this issue Jan 27, 2022 · 4 comments

Comments

@txtsd
Copy link

txtsd commented Jan 27, 2022

With a password that contains extended ASCII (eg: »ø¦ÿÜ¿öÏàäÿí£Ê·Ìõ¾µ), I'm able to login to the website just fine.

I'm also able to retrieve my list of characters in the client fine.

Although, after selecting a character, the client disconnects and goes back to the login screen.

This is what the log shows:

ERROR - 2022-01-27 22:41:39,152 - [LWJGL Application]: Book ID: 417 not found. File goodregent.book.xml is missing in the resources.
WARN  - 2022-01-27 22:42:05,510 - [LWJGL Application]: Changing the locale will not effect ALL loaded resource bundles. TextRenderer should work now tho :)
WARN  - 2022-01-27 22:42:09,660 - [pool-7-thread-1]: Disconnect received: Connection was stopped by the server.
Reason: The password is wrong.
ERROR - 2022-01-27 22:42:09,681 - [Illarion input thread]: The connection to the server is not working anymore.
java.io.IOException: Connection reset by peer
	at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
	at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
	at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
	at sun.nio.ch.IOUtil.read(IOUtil.java:192)
	at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
	at illarion.client.net.Receiver.receiveData(Receiver.java:424)
	at illarion.client.net.Receiver.run(Receiver.java:274)
WARN  - 2022-01-27 22:42:09,700 - [Illarion input thread]: Disconnect received: A technical problem in Receiver thread has occurred. Check logfiles for details.
ERROR - 2022-01-27 22:42:09,767 - [pool-6-thread-1]: Connection failure: Broken pipe

I was able to get ingame after changing my password to one that doesn't have extended ASCII in it.

In this age of password managers, it's very important to be able to handle any kind of password.

(I'm not sure if the problem is in the client or the server, so feel free to move the issue to the server repo if the issue stems from there.)

@estralis
Copy link
Member

estralis commented Jan 27, 2022

@txtsd
Copy link
Author

txtsd commented Jan 27, 2022

@voidowl-rl
Copy link
Contributor

The results of the PHP crypt() function and of the clients encrypting function differ for "non-ascii" input.

Most probably a faulty implementation of MDd5Crypt on the clients side.

Side note: as the algorithm used by phps crypt-function is version and OS dependent, this should also be switched to a fixed algorithm.

@estralis
Copy link
Member

estralis commented Jan 2, 2023

https://illarion.org/mantis/view.php?id=6242 https://illarion.org/mantis/view.php?id=8936

Access Denied.

:(

The Mantis tickets describe the same problem/issue, so I linked them here for completeness. Mantis is not used actively for bugtracking anymore but is still a helpful archive of reports/details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants