Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate a code formatter and a linter #121

Open
algomaster99 opened this issue Sep 9, 2020 · 2 comments
Open

Integrate a code formatter and a linter #121

algomaster99 opened this issue Sep 9, 2020 · 2 comments

Comments

@algomaster99
Copy link
Member

Is your feature request related to a problem? Please describe.
Many pull requests to the omniport ecosystem have mistakes in formatting and more than half of the comments are about the same.

Describe the solution you'd like
Integrate a code formatter as a management command. Further, we can also add it as git hooks to other repositories.

Describe alternatives you've considered
Manually correct formatting - which is a pain and delays a bug fix or a feature addition

Want to take up?
In future but can surely review.

@dhruvkb
Copy link
Member

dhruvkb commented Sep 10, 2020

Whatever linter you use, do not use Black. The core code has been written in a way that is very much against the Black rules.

@algomaster99
Copy link
Member Author

Cool, will keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants