Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo is broken with IE : Inform users about problems of compatibility with their browser #27

Open
gmaillet opened this issue Feb 17, 2016 · 10 comments
Assignees

Comments

@gmaillet
Copy link

The demo doesn't work with IE: it would be nice to inform the user and to suggest to change his browser.

@tbroyer
Copy link
Contributor

tbroyer commented Feb 17, 2016

FWIW, the website at http://itowns.github.io/ will inform the user, but indeed not the demos themselves.

@mbredif mbredif changed the title Inform users about problems of compatibility with their browser Demo is broken with IE : Inform users about problems of compatibility with their browser Feb 17, 2016
@mbredif
Copy link
Member

mbredif commented Feb 17, 2016

I have just put a more informative title. could you please provide some info on the incompatibility (error message, console log, https://get.webgl.org/ status...)

@vcoindet
Copy link

  • IE 11 doesn't seem to support "Promise()"
  • Console.log : SCRIPT5009: "Promise" is undefined (file itowns.js, l.18)
  • https://get.webgl.org/ status : IE supports WebGL

For now I propose an alert box to warn users that itowns is not supported by IE and invite them to use chrome or firefox on windows.

@nosy-b
Copy link
Contributor

nosy-b commented Feb 18, 2016

How can we make a automatic conformance test on the builds/release? @tbroyer

@gcebelieu
Copy link
Member

Maybe this can fill the gap between ie11 and promise : https://github.com/stefanpenner/es6-promise

@tbroyer
Copy link
Contributor

tbroyer commented Feb 18, 2016

@nosy-b Depends what you want to test :-)

ESLint 2.x would choke on the new Promise() we have here, but it would choke on so many other things too that it would require time to be configured; or we could start with reformatting the code using, e.g. JS-Beautify, and dumbing down a few ESLint rules to mere warnings rather than errors.
…or we start "from scratch" and only enable the few rules we want (no-undef here)

Another solution is to run automated tests in browsers (through SauceLabs' OpenSauce), but that means such tests must exists (could possibly be as easy as running the sample and looking for errors, still this would have to be automated somehow)

@gcebelieu this file imports when, which implements a form of promises AFAICT (although different from "native" promises).

@vpicavet
Copy link
Contributor

I would say we do not support IE at all for the moment in itowns 1, just alert the user
As for a test framework, probably better to concentrate on itowns2 as well. Let's open issues there.

@vcoindet
Copy link

I agree. I've already made an alert message to warn users that iTowns is not supported by IE when they are trying to open the project with IE.
Just have to push it.

@tbroyer
Copy link
Contributor

tbroyer commented Feb 18, 2016

If supporting IE11 is only a matter of fixing that Promise, I think we should do it (fun fact: in my Windows 7 VM in Virtual Box, IE11 has WebGL but neither Firefox nor Chrome has it). Older IE versions don't have WebGL anyway (and moreover are no longer supported by Microsoft).

Re. test automation et al. in V2, see iTowns/itowns#45. I'll setup Travis-CI as soon as it's merged in (we could also use AppVeyor for a basic Windows build BTW).

@gcebelieu
Copy link
Member

IE11 support may be optional for itowns v1, but it isn't for itowns v2 if we want to use it for geoportal web site. We will have to fix it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants