-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo is broken with IE : Inform users about problems of compatibility with their browser #27
Comments
FWIW, the website at http://itowns.github.io/ will inform the user, but indeed not the demos themselves. |
I have just put a more informative title. could you please provide some info on the incompatibility (error message, console log, https://get.webgl.org/ status...) |
For now I propose an alert box to warn users that itowns is not supported by IE and invite them to use chrome or firefox on windows. |
How can we make a automatic conformance test on the builds/release? @tbroyer |
Maybe this can fill the gap between ie11 and promise : https://github.com/stefanpenner/es6-promise |
@nosy-b Depends what you want to test :-) ESLint 2.x would choke on the Another solution is to run automated tests in browsers (through SauceLabs' OpenSauce), but that means such tests must exists (could possibly be as easy as running the sample and looking for errors, still this would have to be automated somehow) @gcebelieu this file imports |
I would say we do not support IE at all for the moment in itowns 1, just alert the user |
I agree. I've already made an alert message to warn users that iTowns is not supported by IE when they are trying to open the project with IE. |
If supporting IE11 is only a matter of fixing that Re. test automation et al. in V2, see iTowns/itowns#45. I'll setup Travis-CI as soon as it's merged in (we could also use AppVeyor for a basic Windows build BTW). |
IE11 support may be optional for itowns v1, but it isn't for itowns v2 if we want to use it for geoportal web site. We will have to fix it anyway. |
The demo doesn't work with IE: it would be nice to inform the user and to suggest to change his browser.
The text was updated successfully, but these errors were encountered: