Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add suggestions to 404 feature page #1214

Open
jcscottiii opened this issue Feb 26, 2025 · 2 comments
Open

[ENHANCEMENT] Add suggestions to 404 feature page #1214

jcscottiii opened this issue Feb 26, 2025 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jcscottiii
Copy link
Collaborator

jcscottiii commented Feb 26, 2025

Background: GoogleChrome/chromium-dashboard#4811 (comment)

Idea:

Given I am a user going to a nonexistent feature page features/${BAD_ID}, upon reaching the 404 page (Maybe we should make a 404 page just for feature requests), I should see a list of suggested feature ids if they exist.

Implementation:

  • The 404 feature page should make a query to the /v1/features API with the query parameter set to q=${BAD_ID}. If it gets any results back, present the list as a suggested list of features.

Other alternatives:

  • Replacing the "Go back home" button with a "Search for similar names" button?
@Jynx2004
Copy link

Jynx2004 commented Mar 4, 2025

Hello @jcscottiii . I have come up with a solution . Maybe we can show the list of suggested features if we get the response from the
/v1/features API with the query parameter set to q=${BAD_ID} . But if we get an empty response , then we can show a button displaying "Search for similar names".

@jcscottiii
Copy link
Collaborator Author

I have come up with a solution . Maybe we can show the list of suggested features if we get the response from the /v1/features API with the query parameter set to q=${BAD_ID} . But if we get an empty response , then we can show a button displaying "Search for similar names".

Hi @Jynx2004,

I am trying to understand your proposed solution. Are you proposing a separate endpoint to search for similar names? Currently, the only way to search for similar named features would be to use /v1/features?q=BAD_ID. So that would give us the same list regardless if we show the list on the 404 page or present a button that redirects them to the homepage search with the same BAD_ID (which then would use /v1/features?q=BAD_ID).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants