[HOLD for regression test] [$250] android - Chat - In room chat, edit comment shows suggestion list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.22
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4872065
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap fab -- start chat -- room
3. Create a room
4. Enter @[email protected]
5. Send the message
6. In whishper message, tap invite
7. Long press the message sent in step 4, and select edit comment

Expected Result:

In room chat, edit comment must not show suggestion list

Actual Result:

In room chat, edit comment shows suggestion list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6576278_1724089106513.Screenrecorder-2024-08-19-23-00-34-335_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016746ee733b120550
• Upwork Job ID: 1828406003775672724
• Last Price Increase: 2024-09-03
• Automatic offers:
• mkhutornyi | Reviewer | 103882312

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[melvin-bot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016746ee733b120550

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[mkhutornyi]

Awaiting proposals

[kaushiktd]

@mkhutornyi when long press on any message, you can see only three option like: Mark as read, Copy to clipboard and copy link. There is no option to edit the message.

[melvin-bot]

@miljakljajic @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mkhutornyi]

Still awaiting proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[miljakljajic]

Thank you! I'll assign you

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[miljakljajic]

Reassigning for parental leave. Thanks @muttmuure

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Avoid suggestion box calculation on firs input focus #49589

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @JKobrynski does not require payment (Contractor)
• @mkhutornyi requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[muttmuure]

@mkhutornyi paid

[muttmuure]

Can we get a regression test please?

[mkhutornyi]

Can we get a regression test please?

Seems already exist
https://expensify.testrail.io/index.php?/tests/view/4872065

[muttmuure]

cool cool, thanks