Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shr_flux_mod update to use shr_wv_sat_mod #854

Closed
jedwards4b opened this issue Nov 30, 2016 · 2 comments
Closed

shr_flux_mod update to use shr_wv_sat_mod #854

jedwards4b opened this issue Nov 30, 2016 · 2 comments

Comments

@jedwards4b
Copy link
Contributor

This issue is moved from CESM-DEVELOPMENT issue 39.
shr_flux_mod should use the saturation vapor pressure from shr_wv_sat_mod instead of
having it's own method.
Any of the common approximation methods will give effectively the same answer at reasonable temperatures/pressures over the ocean, and this is not performance-critical code that needs optimization. Still, it's better practice to call the standard routine than to have a series of duplicated/hard-coded formulas, so this should probably be cleaned up some time.

The one caveat is that there's a factor of 0.98 applied to the humidity, which roughly adjusts for the ocean salinity. That factor needs to be kept, in the subroutines where it is present to begin with.

@jgfouca
Copy link
Contributor

jgfouca commented Sep 26, 2018

Check if done.

@billsacks
Copy link
Member

Moved to ESCOMP/CESM_share#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants