Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling IPv4, and IPv4-mapped IPv6 #6

Open
jbmagination opened this issue Dec 6, 2021 · 2 comments
Open

Handling IPv4, and IPv4-mapped IPv6 #6

jbmagination opened this issue Dec 6, 2021 · 2 comments
Labels
container Related to the container

Comments

@jbmagination
Copy link
Member

This has been moved from a comment.

Seeing 1613f6a, checkIP has been changed to resolve #4:

function checkIP(intake: String) {
     intake = intake.replace('::ffff:', '');

I fear the way this has been changed could be a problem when IPv6 becomes standard.

::ffff: signifies that this is an IPv4-mapped IPv6 address. 0.0.0.0 in IPv4 would look like ::ffff:0.0.0.0 in IPv6.

I think the proper thing to do here would be to adapt all IP's handled that are IPv4 to IPv4-mapped IPv6. The IP's can be treated the same way regardless of source and IP compatibility.

@sudocode1
Copy link
Member

Does this even cause an issue? This would only replace ::ffff: not every prefix.

@sudocode1 sudocode1 added the container Related to the container label Dec 8, 2021
@jbmagination
Copy link
Member Author

It could potentially cause issues as IPv6 becomes standard. Converting IPv4 to IPv6 will be an encouraging factor for more widespread acceptance of IPv6 (which is very needed, they keep running out of IPv4 addresses)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Related to the container
Projects
None yet
Development

No branches or pull requests

2 participants