Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog reporting no trace for netty 4.1 when request is cancelled #8118

Open
furstenheim-goodnotes opened this issue Dec 19, 2024 · 0 comments

Comments

@furstenheim-goodnotes
Copy link

furstenheim-goodnotes commented Dec 19, 2024

Using kotlin and netty engine if a client request is aborted in flight, then datadog is reporting no trace.

On the client I can reproduce it with:

it("cancellation", async () => {
    const content = '123456789'
    const body = new stream.Readable()

    const abortableController = new AbortController()
    body._read = () => {}
    setImmediate(async () => {
        body.push(content.slice(0, 5)) // send part of the request
        await wait(1000)
        abortableController.abort() // abort
       // not aborted request would do body.push(content.slice(5)); body.push(null)
    })
    await axios({
        url: 'http://localhost:3044/test',
        method: 'POST',
        data: body,
        signal: abortableController.signal,
        headers: {
            'Content-Length': content.length,
            'Content-Type': 'text/plain'
        }
    })
})

If finishing the request without aborting the server will show datadog trace.

My guess is that there is an issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant