Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Matrix client should only sync information relevant to the current page #24

Open
Stvad opened this issue Dec 31, 2022 · 2 comments
Labels
performance Ways to improve speed

Comments

@Stvad
Copy link
Contributor

Stvad commented Dec 31, 2022

I noticed that the client seems to be doing sync for all the messages, and as a consequence it takes a while to load the highlights.
It should be configured to do sync with filter only on the relevant room by default.

@DanilaFe
Copy link
Owner

DanilaFe commented Jan 1, 2023

I've definitely had this in mind, but last time I looked into it, I remember running into trouble (the precise sort of trouble I do not currently recall). On the other hand, with the present architecture, there's a single Matrix client for all pages; this means it will at the very least need to switch filters whenever a new page is "opened".

@DanilaFe DanilaFe added the performance Ways to improve speed label Jan 1, 2023
@Stvad
Copy link
Contributor Author

Stvad commented Jan 1, 2023

can probably route to a specific client based on source tab id/url 🤔 from event.

I'm also actually not convinced that running the client in the content script is such a bad idea 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Ways to improve speed
Projects
None yet
Development

No branches or pull requests

2 participants