Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deploy storybook when checks for success fail #24

Open
2 tasks
patcon opened this issue Oct 22, 2024 · 3 comments
Open
2 tasks

Don't deploy storybook when checks for success fail #24

patcon opened this issue Oct 22, 2024 · 3 comments

Comments

@patcon
Copy link
Member

patcon commented Oct 22, 2024

Re: https://github.com/bitovi/github-actions-storybook-to-github-pages

We need to run deploy after the checks for success. Just realized in the CI run that it was deploying the the action step, and so a failure didn't matter. We want deploy in a separate step, so it doesn't happen
https://github.com/CivicTechTO/polis-storybook/actions/runs/11469336432/job/31916377978

To Do

  • move deploy step after the step where checking for PR build success (so deploy doesn't happen before the check)
  • run check for main storybook building (currently only attempting to check PR builds)
@patcon patcon changed the title Don Don't deploy storybook when checks for success fail Oct 22, 2024
@patcon
Copy link
Member Author

patcon commented Oct 22, 2024

Also, we should have a way to check for failures in the main build. This should be rare if we use PRs, but ca n happen if we push direct to main. Maybe this is a separate ticket tho

@thomassth
Copy link
Contributor

Rule added

@patcon
Copy link
Member Author

patcon commented Oct 26, 2024

Thanks for chipping in with issue queue gardening, but this isn't yet started. Added specific todos to make that clear 🙏

@patcon patcon reopened this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants