Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks which were not broken in the first place are marked as being repaired #205

Open
Borewit opened this issue Sep 19, 2023 · 2 comments
Labels
bug Something isn't working Could not be reproduced The reported problem could not be reproduced following the provided instructions

Comments

@Borewit
Copy link
Owner

Borewit commented Sep 19, 2023

          **Additional information pertaining to listFix 2.8.0 & 2.8.0-7**
  1. After Step 3 above, having saved the first round of repairs (i.e. the exact matches) the corresponding matches in the playlist are marked with an "OK" icon to reflect its current status.

image

  1. If one should now proceed to next find the closest matches for the remaining tracks, the "OK" icon for the exact matches already found, is summarily replaced by a checkmark. An unnecessary duplication? Saved matches should remain saved, should it not, and the process to find the closest matches should only be applicable to the remainder of the tracks in need of repair.

image

Originally posted by @touwys in #194 (comment)

@Borewit Borewit added the bug Something isn't working label Sep 19, 2023
@Borewit
Copy link
Owner Author

Borewit commented Sep 19, 2023

I have seen you screen capture @touwys, but I cannot get it reproduced. When I try all tracks are staying at the "Ok" state.

@touwys
Copy link

touwys commented Sep 20, 2023

I have seen you screen capture @touwys, but I cannot get it reproduced. When I try all tracks are staying at the "Ok" state.

I can repeatedly reproduce it. Did you cancel/close the first progress window once all the exact matches were found? However, in retrospect, it must have been the intention all along that it should behave like this, to discard any previously saved changes indicated by the OK-icon. Because, it repeats even when both operations (i.e. finding the exact+the closest matches) are allowed to complete. Thus, if this complete repair process is re-initiated at any time, it will again discard all the saved tracks indicated with the OK-icon.

@Borewit Borewit added the Could not be reproduced The reported problem could not be reproduced following the provided instructions label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Could not be reproduced The reported problem could not be reproduced following the provided instructions
Projects
None yet
Development

No branches or pull requests

2 participants