Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeStatus::IDLE when action is preempting. #17

Open
Timple opened this issue May 31, 2022 · 2 comments
Open

NodeStatus::IDLE when action is preempting. #17

Timple opened this issue May 31, 2022 · 2 comments

Comments

@Timple
Copy link

Timple commented May 31, 2022

setStatus(NodeStatus::IDLE);

Often actionclients can stop at once if they are asked to (like calculating fibonacci numbers).

But somethings it takes time to cleanup (PREEMPTING state). Like writing large files, getting to a safe state.

I would say the NodeStatus should only be idle when the state is PREEMPTED, not PREEMPTING.

simple_client_state_transitions
source

@facontidavide
Copy link
Collaborator

I think you are correct. I am about to refactor this, and I will take this suggestion into account

@Timple
Copy link
Author

Timple commented Aug 1, 2022

Did you already start on the refactor?
Otherwise I'll make a pull-request only implementing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants