Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum required versions of Node and npm #7722

Open
donnapep opened this issue Jan 9, 2025 · 1 comment
Open

Bump the minimum required versions of Node and npm #7722

donnapep opened this issue Jan 9, 2025 · 1 comment
Labels
[Pri] Normal Can wait for the next release [Type] Technical Debt
Milestone

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jan 9, 2025

As per this post, WordPress Core and Gutenberg are on Node >=20.10.0 and npm >=10.2.3. We should update Sensei to match.

As part of this work, we should remove the hard-coded Node requirement from the GitHub workflows that were added in #7720.

Note that upgrading Node was already started in https://github.com/Automattic/sensei-security/pull/15.

@donnapep donnapep added [Pri] Normal Can wait for the next release [Type] Technical Debt labels Jan 9, 2025
@donnapep donnapep added this to the 4.24.6 milestone Jan 9, 2025
@donnapep
Copy link
Collaborator Author

donnapep commented Jan 29, 2025

Also linking here for consideration / discussion the idea of eliminating the .nvmrc file:

In order to bring down technical debt, whenever a developer works on a site and rebuilds the assets, they should also update the packages and the engines entry in the package.json file, and try to fix any incompatibilities. It should be much easier to upgrade from Node.js 16 to 18 and so on than from Node.js 16 to 24 when the current packages are likely to first break.

We feel that including an .nvmrc file would be counter-productive to this goal of "forcing" maintainers to upgrade the packages and the Node.js version.

It could be contributing to the situation we find ourselves in now with outdated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Type] Technical Debt
Projects
None yet
Development

No branches or pull requests

1 participant