Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time field for produced blocks is wrong and the name time is confusing with received block's time #849

Closed
linh2931 opened this issue Oct 1, 2024 · 0 comments · Fixed by #856 or #850
Closed

time field for produced blocks is wrong and the name time is confusing with received block's time #849

linh2931 opened this issue Oct 1, 2024 · 0 comments · Fixed by #856 or #850
Assignees
@linh2931
Labels
bug The product is not working as was intended. 👍 lgtm
Milestone
Spring v1.0.2

Comments

@linh2931
Copy link
Member

linh2931 commented Oct 1, 2024 •
edited
Loading

The time field reported for Produced block is wrong:

node_bios/stderr.2024_10_01_11_52_13.txt:info 2024-10-01T15:53:04.594 nodeos controller.cpp:3475 log_applied ] Produced block 0de718e5b389a264... #104 @ 2024-10-01T15:53:05.000 signed by eosio [trxs: 0, lib: 102, confirmed: , net: 0, cpu: 100, elapsed: 234 us, time: 1727797984594382 us]

This happens in both main and rel 1.0 branches.

Both produced blocks and received blocks use the same short name time, which is confusing. It would be cleaner to use producing time and applying time.

cpu field could add postfix us in the same way as other time.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Oct 1, 2024
@linh2931 linh2931 added the bug The product is not working as was intended. label Oct 1, 2024
@linh2931 linh2931 changed the title time field for produced blocks is wrong and the name time is confused with received block's time time field for produced blocks is wrong and the name time is confusing with received block's time Oct 1, 2024
@linh2931 linh2931 self-assigned this Oct 1, 2024
@linh2931 linh2931 mentioned this issue Oct 1, 2024
Merged
@linh2931 linh2931 moved this from Todo to Reviewer Approved in Team Backlog Oct 1, 2024
@linh2931 linh2931 added this to the Spring v1.0.2 milestone Oct 1, 2024
@linh2931 linh2931 mentioned this issue Oct 1, 2024
Merged
@arhag arhag linked a pull request Oct 1, 2024 that will close this issue
[1.0.2] Fix reported time for produced blocks and fix confusing reported time name #850
Merged
@arhag arhag added 👍 lgtm and removed triage labels Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Team Backlog Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
bug The product is not working as was intended. 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.2
3 participants
@arhag @linh2931 @enf-ci-bot