Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid block exceptions logged as errors #70

Closed
heifner opened this issue Apr 25, 2024 · 0 comments · Fixed by #83
Closed

Invalid block exceptions logged as errors #70

heifner opened this issue Apr 25, 2024 · 0 comments · Fixed by #83
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Apr 25, 2024

Currently invalid (including unlinkable, out-of-order) blocks received and pushed into the controller are logged as error. Since invalid blocks from the network cause no harm as they are properly discarded, seems we should log these "errors" as info level logs, not error level logs.

Example:

error 2024-04-25T11:44:34.372 nodeos    producer_plugin.cpp:796       operator()           ] Exception on block 163: 3030001 unlinkable_block_exception: Unlinkable block
unlinkable block 000000a3ee4fa651bbcc477acccc5f96ed7c6fd32997277ce0f20fe8a4d78563 previous 000000a2ba874feef32fa22d019bd5b8a8c4211ed48f8c19cb9ba2371a65d17c
    {"id":"000000a3ee4fa651bbcc477acccc5f96ed7c6fd32997277ce0f20fe8a4d78563","p":"000000a2ba874feef32fa22d019bd5b8a8c4211ed48f8c19cb9ba2371a65d17c"}
    chain-1  controller.cpp:3792 operator()
@heifner heifner self-assigned this Apr 26, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Apr 26, 2024
heifner added a commit that referenced this issue Apr 26, 2024
…need user action. Also move some producing log statements to the producer logger instead of the default logger.
@heifner heifner linked a pull request Apr 26, 2024 that will close this issue
heifner added a commit that referenced this issue Apr 27, 2024
IF: Avoid error logging of errors that do not require action
@heifner heifner closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants