Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Test Failure: snapshot_in_svnn_transition_test #62

Closed
heifner opened this issue Apr 23, 2024 · 0 comments · Fixed by #64
Closed

IF: Test Failure: snapshot_in_svnn_transition_test #62

heifner opened this issue Apr 23, 2024 · 0 comments · Fixed by #64
Assignees
@linh2931
Labels
bug The product is not working as was intended.
Milestone
Savanna: Producti...

Comments

@heifner
Copy link
Member

heifner commented Apr 23, 2024

https://github.com/AntelopeIO/spring/actions/runs/8801519365/job/24155565450

The request for the snapshot of block 93 came in too late to the node so it was not processed. Seems the test should not request a specific block or it should request a block more than 1 in the future to avoid this race condition.
@linh2931 linh2931 self-assigned this Apr 23, 2024
@linh2931 linh2931 added the bug The product is not working as was intended. label Apr 23, 2024
@linh2931 linh2931 added this to the Savanna: Production-Ready milestone Apr 23, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Apr 23, 2024
@linh2931 linh2931 mentioned this issue Apr 23, 2024
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Apr 23, 2024
@linh2931 linh2931 linked a pull request Apr 23, 2024 that will close this issue
Fix scheduled snapshot requests coming too late in snapshot_in_svnn_transition_test #64
Merged
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
bug The product is not working as was intended.
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
2 participants
@heifner @linh2931