Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_block_header_state for EOSJS support #39

Closed
heifner opened this issue Feb 7, 2024 · 3 comments · Fixed by #40
Closed

Change get_block_header_state for EOSJS support #39

heifner opened this issue Feb 7, 2024 · 3 comments · Fixed by #40
Assignees
Labels
bug The product is not working as was intended. 👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Feb 7, 2024

eosjs

eosjs uses get_block_header_state for TAPOS. Modify get_block_header_state to only return the block header and id needed for eosjs. All other fields should provide some invalid value rather than the actual values to remove dependencies on the legacy block header state that goes away after the IF transition.

@ericpassmore
Copy link
Contributor

@heifner
Copy link
Member Author

heifner commented Feb 7, 2024

@arhag arhag changed the title IF: Add back get_block_header_state for EOSJS support Change get_block_header_state for EOSJS support Feb 9, 2024
@ericpassmore
Copy link
Contributor

ericpassmore commented Feb 9, 2024

Note:start
group: PROTOCOL
category: HTTP
summary: Update get_block_header_state to return valid values for required fields. This keeps backward compatibility with eosjs TAPOS.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. 👍 lgtm
Projects
Status: Done
5 participants