Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Failure: nodeos_read_terminate_at_block_if_lr_test #38

Closed
linh2931 opened this issue Apr 16, 2024 · 1 comment · Fixed by #61
Closed

Test Failure: nodeos_read_terminate_at_block_if_lr_test #38

linh2931 opened this issue Apr 16, 2024 · 1 comment · Fixed by #61
Assignees
@linh2931
Labels
bug The product is not working as was intended. 👍 lgtm
Milestone
Savanna: Producti...

Comments

@linh2931
Copy link
Member

https://github.com/AntelopeIO/spring/actions/runs/8707646627/job/23883711651#step:4:711
@heifner
Copy link
Member

heifner commented Apr 16, 2024

Failure of terminate-at-block when running in irreversible mode. This failure is caused by blocks being able to be applied during log_irreversible. The terminate_at_block checks chain_head in push_block. This allows bsp to be added to the forkdb and processed during log_irreversible. Need to check bsp in push_block and not allow it to be processed if > than terminate_at_block.

@arhag arhag added bug The product is not working as was intended. 👍 lgtm labels Apr 17, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Apr 17, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Apr 17, 2024
@linh2931 linh2931 mentioned this issue Apr 23, 2024
Merged
@heifner heifner linked a pull request Apr 23, 2024 that will close this issue
IF: Missing vote logging and Prometheus logging of votes #63
Merged
@heifner heifner removed a link to a pull request Apr 23, 2024
IF: Missing vote logging and Prometheus logging of votes #63
Merged
@arhag arhag linked a pull request Apr 24, 2024 that will close this issue
Fix occasional terminate_at_block failures #61
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Apr 29, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
bug The product is not working as was intended. 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

Fix occasional terminate_at_block failures AntelopeIO/spring
3 participants
@heifner @arhag @linh2931