Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up hotstuff directory after unification #12

Closed
linh2931 opened this issue Jan 11, 2024 · 0 comments · Fixed by #30
Closed

Clean up hotstuff directory after unification #12

linh2931 opened this issue Jan 11, 2024 · 0 comments · Fixed by #30
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Producti...

Comments

@linh2931
Copy link
Member

This issue document a list of cleanups after unification. The list will be dynamically updated:

  • rename hotstuff directory to finality
  • remove un-needed files
  • drop hs_ in type and variable names
  • rename proposal_id to block_id in all fields
  • remove proposal_digest from pending_quorum_certificate
@linh2931 linh2931 mentioned this issue Jan 11, 2024
Merged
@bhazzard bhazzard added 👍 lgtm and removed triage labels Jan 16, 2024
@arhag arhag transferred this issue from AntelopeIO/leap Apr 10, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Apr 10, 2024
@arhag arhag changed the title IF: clean up hotstuff directory after unification Clean up hotstuff directory after unification Apr 10, 2024
@heifner heifner self-assigned this Apr 15, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Apr 15, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Apr 15, 2024
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-12 Rename proposal_digest to finalizer_digest. Rename proposal_id …
712b12d 
…to block_id.
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-12 Move finality misc tests to unittests
eaa6e74
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-12 Rename hotstuff directory to finality
c8cd1aa
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-12 Rename hotstuff.?pp to quorum_certificate.?pp. Move vote_messag…
8f02ecc 
…e into its own header.
heifner added a commit that referenced this issue Apr 15, 2024
@heifner
GH-12 Rename hs_bitset to vote_bitset. Remove unused code.
92f57fb
@heifner heifner mentioned this issue Apr 15, 2024
Merged
@heifner heifner linked a pull request Apr 15, 2024 that will close this issue
IF: Remove hotstuff references #30
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Apr 15, 2024
heifner added a commit that referenced this issue Apr 16, 2024
@heifner
GH-12 Move finality_core to finality dir. Remove a few more reference…
45f2e15 
…s to hotstuff.
heifner added a commit that referenced this issue Apr 16, 2024
@heifner
GH-12 Add vote threads needed for unittests
c3bdd8a
heifner added a commit that referenced this issue Apr 16, 2024
@heifner
GH-12 Add vote threads
e4010d2
heifner added a commit that referenced this issue Apr 16, 2024
@heifner
GH-12 Add vote threads to tests
bf8fe18
heifner added a commit that referenced this issue Apr 19, 2024
@heifner
Merge remote-tracking branch 'spring/savanna' into GH-12-cleanup
53673ea
heifner added a commit that referenced this issue Apr 19, 2024
@heifner
Merge pull request #30 from AntelopeIO/GH-12-cleanup
64b77f4 
IF: Remove hotstuff references
@heifner heifner closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

IF: Remove hotstuff references AntelopeIO/spring
5 participants
@bhazzard @heifner @arhag @linh2931 @enf-ci-bot