Fix bug where users are not added to system roles

[Alex-Yates]

No description provided.

[paschott]

Are we talking system roles like db_datareader or server-level roles like sysadmin? I'll admit that I hadn't considered server-level roles to be in scope for a database project except maybe cases where this is with the master database.

[Alex-Yates]

Yep, that's right.

Why wouldn't you want to control which users have sa and which users don't?

[Alex-Yates]

(One of the first things my customer queried me on when I showed this to them the other day.)

[paschott]

I just never controlled that at the database project level. That was a "server-level" project type thing. Not saying it's a bad idea, but most of the time I used this was to set permissions to use within a given database, not server-level roles. Maybe another option? :)

Just thinking that if I'm setting permissions for a given DB project, I probably don't want to control server-level roles within that project. That could lead to some confusion as well if one project has the roles set up for LoginA as sysadmin and another one has LoginA as "not sysadmin".

[Alex-Yates]

Ah yes, my bad. I meant database level system stuff. (db_datareader etc).