-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore checksum option for bps #49
Comments
And also a great risk of creating corrupt ROMs if you're careless. Flips is primarily designed for clueless noobs who can't be trusted to know how to answer such a question correctly. Noobs don't know the CLI exists, so I hid the unsafe options there; it's the best compromise I could think of. But yes, it does suck for people who know what they're doing. I believe the best solution is updating the patch on your side. This way, your users will get proper errors if they apply the MSU patch to wrong ROM (for example if they forgot patching SA-1), and also a reasonable guarantee that the patch has been tested and still works. For some patch merging tasks, the correct answer would be a mode that applies multiple patches to the same ROM, then merges the differences. This would ask noobs fewer confusing questions, give proper errors (rather than a corrupt ROM) if the patch is not intended for that ROM or if two patches change the same byte, and a few other advantages. But in this case, the MSU patch builds on SA-1; the patch merger would see a few bytes changed by both, and would complain. I guess it's possible to create a patch from SA-1 v1.6 to v1.7, then use v1.6 as base and pass v1.7 and MSU-1 to a multi-applier, but that's deep into 'can't see the forest for the trees' territory. Unfortunately, Flips is deep into maintenance-only mode. I don't have enough motivation to implement a patch merger, a checksum question, or any other new functionality. |
Ok, I see... thanks for your reply :) |
Hi,
I have many times problems with MSU patches that are in bps format if they want to be combined with other hacks, e.g., latest here where Vitor released a SA-1 patch for gradius (v17), but we only offer a msu support bps for v16:
https://www.zeldix.net/t1522p100-gradius-iii#42157
instead of giving the error message "This patch is not intended for this ROM." could you maybe make a warning instead alike:
"Warning: This patch is not intended for this ROM. Do you want to patch anyway?" And then let the user decide with Yes/No.
The command line :
flips --ignore-checksum --apply patch.bps rom.sfc
is already doing this, but having this option in the GUI would be a great advantage imo!
The text was updated successfully, but these errors were encountered: